Skip to content

chore: remove svc logs features for patch#3960

Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom
dannyrandall:chore/unfeat
Aug 30, 2022
Merged

chore: remove svc logs features for patch#3960
mergify[bot] merged 5 commits intoaws:mainlinefrom
dannyrandall:chore/unfeat

Conversation

@dannyrandall
Copy link
Copy Markdown
Contributor

Revert before v1.22.0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@dannyrandall dannyrandall requested a review from a team as a code owner August 29, 2022 18:28
@dannyrandall dannyrandall requested review from huanjani and removed request for a team August 29, 2022 18:28
Comment thread internal/pkg/cli/svc_logs.go
Copy link
Copy Markdown
Contributor

@paragbhingre paragbhingre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that are we reverting Wanxian's container feature as well?

Comment thread internal/pkg/cli/flag.go
@dannyrandall
Copy link
Copy Markdown
Contributor Author

@paragbhingre yes, we are! that's the --container feature.

@paragbhingre paragbhingre added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 30, 2022
@dannyrandall dannyrandall removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 30, 2022
@mergify mergify Bot merged commit b09da18 into aws:mainline Aug 30, 2022
@dannyrandall dannyrandall deleted the chore/unfeat branch August 30, 2022 16:57
mergify Bot pushed a commit that referenced this pull request Sep 9, 2022
Fixes #3272 and #3961, reverting #3960


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
mergify Bot pushed a commit that referenced this pull request Sep 14, 2022
Revert partially #3960 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants