chore: validate env version for task run --generate-cmd#3987
Merged
mergify[bot] merged 15 commits intoaws:mainlinefrom Sep 22, 2022
Merged
chore: validate env version for task run --generate-cmd#3987mergify[bot] merged 15 commits intoaws:mainlinefrom
task run --generate-cmd#3987mergify[bot] merged 15 commits intoaws:mainlinefrom
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #3987 +/- ##
============================================
- Coverage 68.65% 68.64% -0.02%
============================================
Files 248 248
Lines 35067 35097 +30
Branches 264 264
============================================
+ Hits 24076 24093 +17
- Misses 9801 9813 +12
- Partials 1190 1191 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lou1415926
reviewed
Sep 12, 2022
Lou1415926
reviewed
Sep 12, 2022
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
Overall LGTM! Just two small questions!
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
!
iamhopaul123
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3942. Fails earlier if user's env version doesn't support the
--generate-cmdflag for thetask runcommand due to missing permissions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.