fix: route 53 hosted zone resource should use ref#3995
Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom Sep 12, 2022
Merged
fix: route 53 hosted zone resource should use ref#3995mergify[bot] merged 2 commits intoaws:mainlinefrom
mergify[bot] merged 2 commits intoaws:mainlinefrom
Conversation
Lou1415926
approved these changes
Sep 12, 2022
huanjani
approved these changes
Sep 12, 2022
Codecov Report
@@ Coverage Diff @@
## mainline #3995 +/- ##
=========================================
Coverage 68.63% 68.63%
=========================================
Files 248 248
Lines 35084 35084
Branches 264 264
=========================================
Hits 24081 24081
Misses 9810 9810
Partials 1193 1193 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3977.
InternalWorkloadsHostedZonedoes not supportFn::GetAttin Gov cloud and China partition as aAWS::Route53::HostedZoneresource. We'll useFn::Refinstead.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.