Skip to content

fix: route 53 hosted zone resource should use ref#3995

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
iamhopaul123:internal-hosted-zone-fix
Sep 12, 2022
Merged

fix: route 53 hosted zone resource should use ref#3995
mergify[bot] merged 2 commits intoaws:mainlinefrom
iamhopaul123:internal-hosted-zone-fix

Conversation

@iamhopaul123
Copy link
Copy Markdown
Contributor

@iamhopaul123 iamhopaul123 commented Sep 12, 2022

fixes #3977. InternalWorkloadsHostedZone does not support Fn::GetAtt in Gov cloud and China partition as a AWS::Route53::HostedZone resource. We'll use Fn::Ref instead.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner September 12, 2022 18:59
@iamhopaul123 iamhopaul123 requested review from dannyrandall and removed request for a team September 12, 2022 18:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #3995 (12652a6) into mainline (12652a6) will not change coverage.
The diff coverage is n/a.

❗ Current head 12652a6 differs from pull request most recent head ab86aaf. Consider uploading reports for the commit ab86aaf to get more accurate results

@@            Coverage Diff            @@
##           mainline    #3995   +/-   ##
=========================================
  Coverage     68.63%   68.63%           
=========================================
  Files           248      248           
  Lines         35084    35084           
  Branches        264      264           
=========================================
  Hits          24081    24081           
  Misses         9810     9810           
  Partials       1193     1193           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mergify mergify Bot merged commit fba40de into aws:mainline Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValidationError: Template error: resource InternalWorkloadsHostedZone does not support attribute type Id in Fn::GetAtt

5 participants