feat: add support for SQS FIFO Queue#4014
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #4014 +/- ##
============================================
+ Coverage 68.85% 68.96% +0.11%
============================================
Files 248 248
Lines 35125 35248 +123
Branches 264 264
============================================
+ Hits 24184 24310 +126
+ Misses 9751 9748 -3
Partials 1190 1190
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if aws.BoolValue(q.FIFO.Enable) { | ||
| queue.FIFOQueueConfig = &template.FIFOQueueConfig{ | ||
| Enable: q.FIFO.Enable, | ||
| } | ||
| return queue |
There was a problem hiding this comment.
Can we do like SNS and not have Enable as field in the template type:
| if aws.BoolValue(q.FIFO.Enable) { | |
| queue.FIFOQueueConfig = &template.FIFOQueueConfig{ | |
| Enable: q.FIFO.Enable, | |
| } | |
| return queue | |
| queue.FIFOQueueConfig = &template.FIFOQueueConfig{} | |
| if q.FIFO.IsEnabled() && q.FIFO.Advanced.IsEmpty() { | |
| return queue |
There was a problem hiding this comment.
Yes I was working on the same thing here when I got that comment in SNS PR. The change is coming in the latest commit.
I already have this in place -
if !q.FIFO.IsEnabled() {
return queue
}
if aws.BoolValue(q.FIFO.Enable) {
queue.FIFOQueueConfig = &template.FIFOQueueConfig{}
return queue
}
if !q.FIFO.Advanced.IsEmpty() {
// advanced config ...
}
Let me know if that works
efekarakus
left a comment
There was a problem hiding this comment.
A tiny change and then feel free to remove the label
Lou1415926
left a comment
There was a problem hiding this comment.
LGTM just one final question!
This PR resolves #3828 , resolves #2800
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.