feat: env manifest cdn.terminate_tls#4017
Merged
mergify[bot] merged 39 commits intoaws:mainlinefrom Sep 26, 2022
Merged
Conversation
dannyrandall
requested review from
KollaAdithya
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## mainline #4017 +/- ##
============================================
+ Coverage 68.99% 69.08% +0.09%
============================================
Files 248 248
Lines 35294 35422 +128
Branches 264 264
============================================
+ Hits 24350 24471 +121
- Misses 9752 9760 +8
+ Partials 1192 1191 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
efekarakus
reviewed
Sep 21, 2022
Lou1415926
reviewed
Sep 21, 2022
Co-authored-by: Efe Karakus <efekarakus@gmail.com>
Co-authored-by: Efe Karakus <efekarakus@gmail.com>
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
Co-authored-by: Wanxian Yang <79273084+Lou1415926@users.noreply.github.com>
efekarakus
reviewed
Sep 26, 2022
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great, just a bunch of tiny feedback.
efekarakus
approved these changes
Sep 26, 2022
iamhopaul123
approved these changes
Sep 26, 2022
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
Looks good thank you!
| }) | ||
| if err != nil { | ||
| return Rule{}, err | ||
| } else if len(resp.Rules) == 0 { |
Contributor
There was a problem hiding this comment.
nit: we don't need the else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable TLS termination on
cdn, all currently deployed services must havehttp.redirect_to_httpsset tofalseBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.