feat: add support for SNS FIFO#4018
Merged
mergify[bot] merged 8 commits intoaws:mainlinefrom Sep 23, 2022
Merged
Conversation
paragbhingre
requested review from
KollaAdithya
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## mainline #4018 +/- ##
============================================
+ Coverage 68.96% 68.98% +0.01%
============================================
Files 248 248
Lines 35248 35288 +40
Branches 264 264
============================================
+ Hits 24310 24342 +32
- Misses 9748 9754 +6
- Partials 1190 1192 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lou1415926
reviewed
Sep 21, 2022
efekarakus
reviewed
Sep 21, 2022
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Thanks for quickly addressing the manifest changes!
efekarakus
reviewed
Sep 22, 2022
Lou1415926
reviewed
Sep 22, 2022
efekarakus
approved these changes
Sep 22, 2022
efekarakus
added
the
do-not-merge
efekarakus
removed
the
do-not-merge
Lou1415926
approved these changes
Sep 23, 2022
Contributor
Lou1415926
left a comment
Lou1415926
left a comment
There was a problem hiding this comment.
LGTM! just a nit. Adding the DNM in case you'd like to address!
Lou1415926
added
the
do-not-merge
paragbhingre
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix 1st part of #3828
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.