fix: target_container incorrectly using main container port/protocol#4047
Merged
mergify[bot] merged 11 commits intoaws:mainlinefrom Oct 5, 2022
Merged
fix: target_container incorrectly using main container port/protocol#4047mergify[bot] merged 11 commits intoaws:mainlinefrom
mergify[bot] merged 11 commits intoaws:mainlinefrom
Conversation
dannyrandall
requested review from
iamhopaul123
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## mainline #4047 +/- ##
=========================================
Coverage 69.08% 69.09%
=========================================
Files 248 248
Lines 35423 35434 +11
Branches 264 264
=========================================
+ Hits 24472 24483 +11
+ Misses 9760 9759 -1
- Partials 1191 1192 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iamhopaul123
approved these changes
Sep 29, 2022
efekarakus
reviewed
Sep 29, 2022
Contributor
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Looks great, just a question
dannyrandall
changed the title
target_container incorrectly using main container port
iamhopaul123
reviewed
Oct 4, 2022
efekarakus
reviewed
Oct 5, 2022
efekarakus
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4041
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.