feat: Allow adding VPC flow logs in environments#4088
Merged
mergify[bot] merged 10 commits intoaws:mainlinefrom Oct 19, 2022
Merged
feat: Allow adding VPC flow logs in environments#4088mergify[bot] merged 10 commits intoaws:mainlinefrom
mergify[bot] merged 10 commits intoaws:mainlinefrom
Conversation
Codecov Report
@@ Coverage Diff @@
## mainline #4088 +/- ##
============================================
+ Coverage 69.16% 69.18% +0.01%
============================================
Files 248 248
Lines 35606 35610 +4
Branches 264 264
============================================
+ Hits 24628 24635 +7
+ Misses 9783 9781 -2
+ Partials 1195 1194 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
There was a problem hiding this comment.
Can we also add integ test for this feature at https://github.com/aws/copilot-cli/blob/b8c21b1023d0c6c8fe9aa22b1917183a42b2192e/internal/pkg/deploy/cloudformation/stack/env_integration_test.go ? Also could you add an example to the PR description for what the VPC flow logs look like?
Lou1415926
reviewed
Oct 14, 2022
huanjani
reviewed
Oct 14, 2022
iamhopaul123
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #3721
Default VPC
Imported VPC
Configured VPC
flow_logs: oncreates a FlowLog with nameAppName-EnvironmentName-FlowLogGroupthat enables you to capture information about the IP traffic going to and from network interfaces in your VPC.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.