fix(cloudfront): tls termination can set without cert or domain

[iamhopaul123]

Fixes #4080

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

[codecov-commenter]

Codecov Report

Merging #4096 (524e625) into mainline (d603bb8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           mainline    #4096      +/-   ##
============================================
- Coverage     69.17%   69.17%   -0.01%     
============================================
  Files           248      248              
  Lines         35609    35607       -2     
  Branches        264      264              
============================================
- Hits          24634    24632       -2     
+ Misses         9781     9779       -2     
- Partials       1194     1196       +2     

Impacted Files	Coverage Δ
internal/pkg/manifest/validate_env.go	84.42% <ø> (-0.95%)	⬇️
internal/pkg/cli/deploy/env.go	75.60% <100.00%> (+0.30%)	⬆️
...ternal/pkg/deploy/cloudformation/cloudformation.go	73.02% <0.00%> (+0.54%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dannyrandall]

looks great!🚀

[paragbhingre]

Looks good to me just one query that I can see we are making sure to enable tls termination even without certs but where are we making sure that it works without domain as well? Or that already happens today?

Feel free to remove label.

[iamhopaul123]

but where are we making sure that it works without domain as well? Or that already happens today?

Yes. In this case CF will use it's own domain and cert. ALB is just plain http.