Skip to content

fix: access logs bucket policy applied after ALB update #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 11, 2022
Merged

fix: access logs bucket policy applied after ALB update #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd184e7
fix: access logs bucket policy applied after ALB update
dannyrandall Nov 11, 2022
64196ee
fix integ tests
dannyrandall Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...oy/cloudformation/stack/testdata/environments/template-with-default-access-log-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,8 @@ Resources:
IpProtocol: -1
SourceSecurityGroupId: !Ref PublicHTTPSLoadBalancerSecurityGroup
ELBAccessLogsBucket:
Metadata:
"aws:copilot:description": "A S3 bucket for the Load Balancer's access logs"
Type: AWS::S3::Bucket
Condition: CreateALB
Properties:
Expand Down Expand Up @@ -770,6 +772,7 @@ Resources:
Metadata:
'aws:copilot:description': 'An Application Load Balancer to distribute public traffic to your services'
Condition: CreateALB
DependsOn: ELBAccessLogsBucketPolicy
Type: AWS::ElasticLoadBalancingV2::LoadBalancer
Properties:
LoadBalancerAttributes:
Expand Down
3 changes: 3 additions & 0 deletions internal/pkg/template/templates/environment/cf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ Resources:
Metadata:
'aws:copilot:description': 'An Application Load Balancer to distribute public traffic to your services'
Condition: CreateALB
{{- if .PublicHTTPConfig.ELBAccessLogs.ShouldCreateBucket}}
DependsOn: ELBAccessLogsBucketPolicy
{{- end}}
Type: AWS::ElasticLoadBalancingV2::LoadBalancer
Properties:
{{- if .PublicHTTPConfig.ELBAccessLogs }}
Expand Down
2 changes: 2 additions & 0 deletions internal/pkg/template/templates/environment/partials/elb-access-logs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ ELBAccessLogsBucketPolicy:
Principal:
AWS: !Join [ "", [ !Sub 'arn:${AWS::Partition}:iam::', !FindInMap [ RegionalConfigs, !Ref 'AWS::Region', ElbAccountId ], ":root" ] ]
ELBAccessLogsBucket:
Metadata:
"aws:copilot:description": "A S3 bucket for the Load Balancer's access logs"
Type: AWS::S3::Bucket
Condition: CreateALB
Properties:
Expand Down