Skip to content

feat: add AutoScalingConfiguration to RDWS#4186

Merged
mergify[bot] merged 6 commits intoaws:mainlinefrom
KollaAdithya:autoconfig
Nov 17, 2022
Merged

feat: add AutoScalingConfiguration to RDWS#4186
mergify[bot] merged 6 commits intoaws:mainlinefrom
KollaAdithya:autoconfig

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

@KollaAdithya KollaAdithya commented Nov 15, 2022

This PR resolves #3200
With this PR we will have a new field count to the Manifest of RequestDrivenService.

count: 'high-availability/3'

In order to use this field customers have to provide AutoScalingConfigurationName/AutoScalingConfigurationRevision as input tocount.

count: AutoScalingConfigurationName/AutoScalingConfigurationRevision

This field will help customers to reference existing autoscaling configurations for different services.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner November 15, 2022 21:55
@KollaAdithya KollaAdithya requested review from paragbhingre and removed request for a team November 15, 2022 21:55
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 15, 2022

🍕 Here are the new binary sizes!

Name New size (kiB) v1.23.0 size (kiB) Delta (%)
macOS (amd) 47676 47548 +0.27
macOS (arm) 47676 48200 ❤️ -1.09
linux (amd) 41928 41824 +0.25
linux (arm) 41928 41220 🥺 +1.72
windows (amd) 38768 38664 +0.27

Comment thread internal/pkg/template/templates/workloads/services/rd-web/cf.yml
Comment thread internal/pkg/template/templates/workloads/services/rd-web/cf.yml Outdated
Comment thread internal/pkg/deploy/cloudformation/stack/testdata/workloads/rdws-test.stack.yml Outdated
Comment thread internal/pkg/template/templates/workloads/services/rd-web/cf.yml Outdated
@KollaAdithya KollaAdithya added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 16, 2022
Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KollaAdithya KollaAdithya removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Nov 17, 2022
Copy link
Copy Markdown
Contributor

@paragbhingre paragbhingre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mergify mergify Bot merged commit ddfe12f into aws:mainline Nov 17, 2022
@miketheman
Copy link
Copy Markdown

Excellent to see this get merged! Is there a separate process to add the count syntax to the docs?

KollaAdithya added a commit to KollaAdithya/copilot-cli that referenced this pull request Nov 21, 2022
This PR resolves aws#3200
With this PR we will have a new field `count` to the  Manifest of RequestDrivenService.
```yaml
count: 'high-availability/3'
```
In order to use this field customers  have to provide `AutoScalingConfigurationName/AutoScalingConfigurationRevision`  as input to`count`.

`count: AutoScalingConfigurationName/AutoScalingConfigurationRevision`

This field will help customers to reference existing autoscaling configurations for different services.



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
@KollaAdithya KollaAdithya deleted the autoconfig branch February 7, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Runner : Please support AutoScalingConfiguration settings in manifest.yml

6 participants