Skip to content

fix: change invalid property SSLPolicy to SslPolicy in CloudFormation template#4278

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
KollaAdithya:fixSsl
Dec 15, 2022
Merged

fix: change invalid property SSLPolicy to SslPolicy in CloudFormation template#4278
mergify[bot] merged 2 commits intoaws:mainlinefrom
KollaAdithya:fixSsl

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

This PR resolves #4269

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner December 15, 2022 20:09
@KollaAdithya KollaAdithya requested review from paragbhingre and removed request for a team December 15, 2022 20:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 15, 2022

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 48628 47904 🥺 +1.51
macOS (arm) 49304 48576 🥺 +1.50
linux (amd) 42740 42124 🥺 +1.46
linux (arm) 42116 41472 🥺 +1.55
windows (amd) 39488 38940 🥺 +1.41

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4278 (77919c5) into mainline (b20a72c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           mainline    #4278   +/-   ##
=========================================
  Coverage     69.92%   69.92%           
=========================================
  Files           253      260    +7     
  Lines         36426    36468   +42     
  Branches        264      264           
=========================================
+ Hits          25471    25502   +31     
- Misses         9733     9743   +10     
- Partials       1222     1223    +1     
Impacted Files Coverage Δ
internal/pkg/override/errors.go 66.66% <0.00%> (-33.34%) ⬇️
internal/pkg/aws/codestar/codestar.go 79.48% <0.00%> (-2.57%) ⬇️
...ternal/pkg/deploy/cloudformation/cloudformation.go 72.47% <0.00%> (-0.55%) ⬇️
internal/pkg/addon/addons.go 87.71% <0.00%> (ø)
internal/pkg/template/env.go 53.52% <0.00%> (ø)
internal/pkg/cli/deploy/env.go 75.19% <0.00%> (ø)
internal/pkg/deploy/cloudformation/stack/env.go 75.13% <0.00%> (ø)
internal/pkg/cli/deploy/rdws.go 40.87% <0.00%> (ø)
internal/pkg/override/override.go 85.00% <0.00%> (ø)
internal/pkg/cli/deploy/job.go 3.22% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!!

@mergify mergify Bot merged commit 5366372 into aws:mainline Dec 15, 2022
@KollaAdithya KollaAdithya deleted the fixSsl branch February 7, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specifying http.public.ssl_policy in the environment manifest creates CloudFormation with incorrect key of SSLPolicy.

5 participants