fix(custom-domain-action): ignore A-record deletion if not found#4409
Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom Jan 25, 2023
Merged
fix(custom-domain-action): ignore A-record deletion if not found#4409mergify[bot] merged 3 commits intoaws:mainlinefrom
mergify[bot] merged 3 commits intoaws:mainlinefrom
Conversation
Fixes aws#4401 If the record fails to insert, then the custom resource fails. On failure, it tries to delete the record that was *not* inserted. Hence the Delete workflow fails resulting in the custom resource to fail to delete. This change ensures that we ignore the error if the A-record that we're trying to delete doesn't exist in the first place.
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Jan 24, 2023
Codecov Report
@@ Coverage Diff @@
## mainline #4409 +/- ##
============================================
- Coverage 70.06% 70.06% -0.01%
============================================
Files 262 262
Lines 37324 37330 +6
Branches 266 268 +2
============================================
+ Hits 26152 26155 +3
- Misses 9915 9919 +4
+ Partials 1257 1256 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
paragbhingre
added
the
do-not-merge
paragbhingre
approved these changes
Jan 25, 2023
Contributor
paragbhingre
left a comment
paragbhingre
left a comment
There was a problem hiding this comment.
Looks good to me. Feel free to remove the label if there is nothing to change.
efekarakus
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4401
If the record fails to insert, then the custom resource fails. On failure, it tries to delete the record that was not inserted. Hence the Delete workflow fails resulting in the custom resource to fail to delete.
This change ensures that we ignore the error if the A-record that we're trying to delete doesn't exist in the first place.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.