fix(template): remove sub from metadata#4562
Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom Feb 28, 2023
Merged
Conversation
efekarakus
reviewed
Feb 28, 2023
| Resources: | ||
| {{logicalIDSafe .Name}}BucketAccessPolicy: | ||
| Metadata: | ||
| 'aws:copilot:description': !Sub |
Contributor
There was a problem hiding this comment.
Is this the only template with !Sub? in the metadata description
efekarakus
approved these changes
Feb 28, 2023
efekarakus
added
the
do-not-merge
|
🍕 Here are the new binary sizes!
|
iamhopaul123
force-pushed
the
fix-access-policy
branch
from
9bb4f5d to
24e23bb
Compare
iamhopaul123
removed
the
do-not-merge
huanjani
reviewed
Feb 28, 2023
| 'aws:copilot:description': !Sub | ||
| - 'An IAM managed policy for your service to access the ${Table} DDB table of your environment' | ||
| - Table: { Fn::ImportValue: { Fn::Sub: "${App}-${Env}-{{logicalIDSafe .Name}}TableName" } } | ||
| 'aws:copilot:description': 'An IAM managed policy for your service to access the DDB table of your environment' |
Contributor
There was a problem hiding this comment.
What if there is more than one DDB table in the env? Does that matter? 🤔 "...access a DDB table in..."??
huanjani
approved these changes
Feb 28, 2023
huanjani
added
the
do-not-merge
iamhopaul123
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4560
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.