Skip to content

fix: sidecar env file ARN CFN resource shouldn't be non-alphanumeric#4714

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
paragbhingre:fixEnvFileARn
Mar 30, 2023
Merged

fix: sidecar env file ARN CFN resource shouldn't be non-alphanumeric#4714
mergify[bot] merged 2 commits intoaws:mainlinefrom
paragbhingre:fixEnvFileARn

Conversation

@paragbhingre
Copy link
Copy Markdown
Contributor

@paragbhingre paragbhingre commented Mar 30, 2023

fixes #4708

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@paragbhingre paragbhingre requested a review from a team as a code owner March 30, 2023 16:20
@paragbhingre paragbhingre requested review from huanjani and removed request for a team March 30, 2023 16:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 30, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50324 50324 ❤️ 0.00
macOS (arm) 50124 50128 ❤️ -0.01
linux (amd) 44304 44300 +0.01
linux (arm) 42560 42564 ❤️ -0.01
windows (amd) 41204 41204 ❤️ 0.00

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.93%. Comparing base (746c78a) to head (a6aeea8).
⚠️ Report is 603 commits behind head on mainline.

Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #4714   +/-   ##
=========================================
  Coverage     69.93%   69.93%           
=========================================
  Files           281      281           
  Lines         40483    40483           
  Branches        272      272           
=========================================
+ Hits          28311    28313    +2     
+ Misses        10810    10807    -3     
- Partials       1362     1363    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Copy link
Copy Markdown
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify Bot merged commit 67db7a2 into aws:mainline Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidecar build with image URL broken after update

5 participants