Skip to content

fix: do record updates in parallel#4772

Merged
mergify[bot] merged 1 commit intoaws:mainlinefrom
bvtujo:bvtujo/domain-lambda-timeouts
Apr 18, 2023
Merged

fix: do record updates in parallel#4772
mergify[bot] merged 1 commit intoaws:mainlinefrom
bvtujo:bvtujo/domain-lambda-timeouts

Conversation

@bvtujo
Copy link
Copy Markdown
Contributor

@bvtujo bvtujo commented Apr 18, 2023

This PR implements the "small" changes in #4711, running the Custom Domain record updates in parallel. It does not implement the large changes, which would imply modifying the cert rather than deleting and recreating it.

Fixes #4711

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@bvtujo bvtujo requested a review from a team as a code owner April 18, 2023 19:30
@bvtujo bvtujo requested review from dannyrandall and removed request for a team April 18, 2023 19:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50500 50328 +0.34
macOS (arm) 50684 50516 +0.33
linux (amd) 44456 44304 +0.34
linux (arm) 42756 42564 +0.45
windows (amd) 41340 41204 +0.33

Copy link
Copy Markdown
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ty!

Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify mergify Bot merged commit 47776ca into aws:mainline Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CustomDomainFunction lambda times out

4 participants