Skip to content

fix: do record updates in parallel #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Apr 18, 2023
Merged

fix: do record updates in parallel #4772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions cf-custom-resources/lib/custom-domain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,43 +100,45 @@ const writeCustomDomainRecord = async function (
aliasTypes,
action
) {
const actions = [];
for (const alias of aliases) {
const aliasType = await getAliasType(aliasTypes, alias);
switch (aliasType) {
case aliasTypes.EnvDomainZone:
await writeARecord(
actions.push(writeARecord(
envRoute53,
alias,
accessDNS,
accessHostedZone,
aliasType.domain,
action
);
));
break;
case aliasTypes.AppDomainZone:
await writeARecord(
actions.push(writeARecord(
appRoute53,
alias,
accessDNS,
accessHostedZone,
aliasType.domain,
action
);
));
break;
case aliasTypes.RootDomainZone:
await writeARecord(
actions.push(writeARecord(
appRoute53,
alias,
accessDNS,
accessHostedZone,
aliasType.domain,
action
);
));
break;
// We'll skip if it is the other alias type since it will be in another account's route53.
default:
}
}
await Promise.all(actions);
};

const writeARecord = async function (
Expand Down