Skip to content

fix: access override templates using forward slashes#4807

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
Lou1415926:fix/overrides/dir/path/windows
Apr 26, 2023
Merged

fix: access override templates using forward slashes#4807
mergify[bot] merged 2 commits intoaws:mainlinefrom
Lou1415926:fix/overrides/dir/path/windows

Conversation

@Lou1415926
Copy link
Copy Markdown
Contributor

Fix #4791

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926 Lou1415926 requested a review from a team as a code owner April 26, 2023 22:57
@Lou1415926 Lou1415926 requested review from dannyrandall and removed request for a team April 26, 2023 22:57
Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh :( my bad

@efekarakus
Copy link
Copy Markdown
Contributor

Thanks for fixing this!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50552 50328 +0.45
macOS (arm) 50760 50516 +0.48
linux (amd) 44500 44304 +0.44
linux (arm) 42820 42564 +0.60
windows (amd) 41376 41204 +0.42

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4807 (c513d06) into mainline (9940e28) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c513d06 differs from pull request most recent head 858c7bc. Consider uploading reports for the commit 858c7bc to get more accurate results

@@            Coverage Diff            @@
##           mainline    #4807   +/-   ##
=========================================
  Coverage     69.99%   69.99%           
=========================================
  Files           286      286           
  Lines         40923    40923           
  Branches        280      280           
=========================================
  Hits          28644    28644           
  Misses        10899    10899           
  Partials       1380     1380           
Impacted Files Coverage Δ
internal/pkg/template/template.go 80.31% <100.00%> (ø)

@mergify mergify Bot merged commit 4fde2d3 into aws:mainline Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Memory Hard Limit setting.

5 participants