Skip to content

docs: fix PolicyName indent#4816

Merged
mergify[bot] merged 2 commits intoaws:mainlinefrom
interu:docs/fix-override-sample
May 1, 2023
Merged

docs: fix PolicyName indent#4816
mergify[bot] merged 2 commits intoaws:mainlinefrom
interu:docs/fix-override-sample

Conversation

@interu
Copy link
Copy Markdown
Contributor

@interu interu commented Apr 29, 2023

The following errors occurred when implemented as per the sample.
"Property PolicyName cannot be empty."

The indentation of PolicyName has been changed for correct operation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@interu interu requested a review from a team as a code owner April 29, 2023 05:44
@interu interu requested review from Lou1415926 and removed request for a team April 29, 2023 05:44
@github-actions
Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50484 50328 +0.31
macOS (arm) 50684 50516 +0.33
linux (amd) 44440 44304 +0.31
linux (arm) 42756 42564 +0.45
windows (amd) 41324 41204 +0.29

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4816 (1c237a1) into mainline (adcd0ce) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           mainline    #4816      +/-   ##
============================================
+ Coverage     69.92%   70.05%   +0.13%     
============================================
  Files           281      287       +6     
  Lines         40503    41126     +623     
  Branches        272      280       +8     
============================================
+ Hits          28321    28811     +490     
- Misses        10817    10928     +111     
- Partials       1365     1387      +22     

see 35 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

Copy link
Copy Markdown
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mergify mergify Bot merged commit 4c29094 into aws:mainline May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants