feat: add --diff-yes flag to copilot [noun] deploy commands#4832
Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom May 3, 2023
Merged
feat: add --diff-yes flag to copilot [noun] deploy commands#4832mergify[bot] merged 5 commits intoaws:mainlinefrom
--diff-yes flag to copilot [noun] deploy commands#4832mergify[bot] merged 5 commits intoaws:mainlinefrom
Conversation
|
🍕 Here are the new binary sizes!
|
Codecov Report
@@ Coverage Diff @@
## mainline #4832 +/- ##
=========================================
Coverage 70.09% 70.10%
=========================================
Files 287 287
Lines 41233 41241 +8
Branches 280 280
=========================================
+ Hits 28904 28910 +6
- Misses 10939 10941 +2
Partials 1390 1390
|
Lou1415926
approved these changes
May 3, 2023
Comment on lines
+265
to
+268
| contd, err := o.skipDiffPrompt, nil | ||
| if !o.skipDiffPrompt { | ||
| contd, err = o.prompt.Confirm(continueDeploymentPrompt, "") | ||
| } |
Contributor
There was a problem hiding this comment.
I think it's okay to write ⬇️ here? Because if we got --diff-yes that means noDeploy should render to false 🤔
if o.skipDiffPrompt {
return true, nil
}
Contributor
Author
There was a problem hiding this comment.
oh I wasn't sure because l.277 in the same method seems to do the actual deployment, so if I were to return it'd skip the deployment altogether I think 💭
iamhopaul123
approved these changes
May 3, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Related: #4832 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4825
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.