Skip to content

chore: implement from_cfn for efs id#5156

Merged
mergify[bot] merged 9 commits intoaws:mainlinefrom
KollaAdithya:from_cfn/efsid
Aug 18, 2023
Merged

chore: implement from_cfn for efs id#5156
mergify[bot] merged 9 commits intoaws:mainlinefrom
KollaAdithya:from_cfn/efsid

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

resolves #5132

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner August 3, 2023 19:22
@KollaAdithya KollaAdithya requested review from iamhopaul123 and removed request for a team August 3, 2023 19:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51628 51488 +0.27
macOS (arm) 51824 51684 +0.27
linux (amd) 45452 45324 +0.28
linux (arm) 43716 43588 +0.29
windows (amd) 42256 42144 +0.27

@KollaAdithya KollaAdithya marked this pull request as draft August 4, 2023 20:41
@KollaAdithya KollaAdithya marked this pull request as ready for review August 8, 2023 22:21
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #5156 (a4421bc) into mainline (ac4145e) will decrease coverage by 0.01%.
Report is 4 commits behind head on mainline.
The diff coverage is 60.45%.

@@             Coverage Diff              @@
##           mainline    #5156      +/-   ##
============================================
- Coverage     69.53%   69.52%   -0.01%     
============================================
  Files           295      295              
  Lines         43713    43836     +123     
  Branches        285      285              
============================================
+ Hits          30394    30476      +82     
- Misses        11838    11875      +37     
- Partials       1481     1485       +4     
Files Changed Coverage Δ
internal/pkg/ecs/ecs.go 75.27% <0.00%> (-2.11%) ⬇️
internal/pkg/manifest/storage.go 93.58% <ø> (ø)
internal/pkg/manifest/validate.go 76.60% <0.00%> (ø)
internal/pkg/template/workload.go 51.20% <0.00%> (-2.61%) ⬇️
internal/pkg/cli/local_run.go 53.35% <29.62%> (-0.01%) ⬇️
internal/pkg/cli/init.go 23.84% <50.00%> (+3.46%) ⬆️
internal/pkg/term/color/color.go 70.83% <89.47%> (+15.99%) ⬆️
internal/pkg/docker/dockerengine/dockerengine.go 83.92% <91.17%> (+0.73%) ⬆️
internal/pkg/cli/deploy/workload.go 61.92% <100.00%> (+0.67%) ⬆️
internal/pkg/cli/env_delete.go 56.70% <100.00%> (-0.59%) ⬇️
... and 6 more

Comment thread internal/pkg/manifest/svc.go Outdated
Comment thread internal/pkg/deploy/cloudformation/stack/testdata/workloads/svc-test.stack.yml Outdated
Comment thread internal/pkg/manifest/svc.go Outdated
Comment thread internal/pkg/template/templates/workloads/partials/cf/taskrole.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add from_cfn option to storage.volumes.<volume>.efs.id

6 participants