fix: skip interpolation of array of strings if the style of node is literal#5157
Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom Aug 8, 2023
Merged
Conversation
|
🍕 Here are the new binary sizes!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #5157 +/- ##
============================================
- Coverage 69.48% 69.48% -0.01%
============================================
Files 295 295
Lines 43367 43367
Branches 285 285
============================================
- Hits 30135 30134 -1
- Misses 11762 11763 +1
Partials 1470 1470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
huanjani
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5155
Literal style helps to break a string into new lines.
In Copilot version v1.29 we supported interpolation of sequence of strings. There is caveat here
If the manifest has
Literal Style(Blocked Scalar) node i.efor example if the manifest contains
This will lead to unmarshal errors.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.