Skip to content

fix: skip interpolation of array of strings if the style of node is literal#5157

Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom
KollaAdithya:interpolate/literal
Aug 8, 2023
Merged

fix: skip interpolation of array of strings if the style of node is literal#5157
mergify[bot] merged 3 commits intoaws:mainlinefrom
KollaAdithya:interpolate/literal

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

@KollaAdithya KollaAdithya commented Aug 3, 2023

Resolves #5155

Literal style helps to break a string into new lines.

In Copilot version v1.29 we supported interpolation of sequence of strings. There is caveat here
If the manifest has Literal Style(Blocked Scalar) node i.e

for example if the manifest contains

labels: 
  "test": |
      ["label1","label2"]

This will lead to unmarshal errors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner August 3, 2023 23:52
@KollaAdithya KollaAdithya requested review from huanjani and removed request for a team August 3, 2023 23:52
@KollaAdithya KollaAdithya changed the title fix: skip interpolation of array of strings if style of node is literal` fix: skip interpolation of array of strings if style of node style is literal Aug 3, 2023
@KollaAdithya KollaAdithya changed the title fix: skip interpolation of array of strings if style of node style is literal fix: skip interpolation of array of strings if the style of node style is literal Aug 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 4, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51496 51488 +0.02
macOS (arm) 51716 51684 +0.06
linux (amd) 45328 45324 +0.01
linux (arm) 43584 43588 ❤️ -0.01
windows (amd) 42152 42144 +0.02

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 4, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.48%. Comparing base (8e39e52) to head (ae8aca2).
⚠️ Report is 360 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5157      +/-   ##
============================================
- Coverage     69.48%   69.48%   -0.01%     
============================================
  Files           295      295              
  Lines         43367    43367              
  Branches        285      285              
============================================
- Hits          30135    30134       -1     
- Misses        11762    11763       +1     
  Partials       1470     1470              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KollaAdithya KollaAdithya changed the title fix: skip interpolation of array of strings if the style of node style is literal fix: skip interpolation of array of strings if the style of node is literal Aug 4, 2023
Copy link
Copy Markdown
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick!

@mergify mergify Bot merged commit dc4ecbe into aws:mainline Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

cannot unmarshal !!seq into string after upgrading to 1.29.0

5 participants