Skip to content

chore: change exit codes of svc/env/job deploy#5179

Merged
mergify[bot] merged 3 commits intoaws:mainlinefrom
KollaAdithya:exit/codes/change
Aug 11, 2023
Merged

chore: change exit codes of svc/env/job deploy#5179
mergify[bot] merged 3 commits intoaws:mainlinefrom
KollaAdithya:exit/codes/change

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

@KollaAdithya KollaAdithya commented Aug 10, 2023

This PR will change the exit codes for copilot svc/env/job deploy when there is an empty changeset for the stack

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner August 10, 2023 00:35
@KollaAdithya KollaAdithya requested review from huanjani and removed request for a team August 10, 2023 00:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 10, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51584 51488 +0.19
macOS (arm) 51788 51680 +0.21
linux (amd) 45408 45324 +0.19
linux (arm) 43716 43588 +0.29
windows (amd) 42216 42144 +0.17

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #5179 (5c32f37) into mainline (9bb319c) will decrease coverage by 0.02%.
The diff coverage is 13.33%.

@@             Coverage Diff              @@
##           mainline    #5179      +/-   ##
============================================
- Coverage     69.55%   69.53%   -0.02%     
============================================
  Files           295      295              
  Lines         43698    43713      +15     
  Branches        285      285              
============================================
+ Hits          30392    30394       +2     
- Misses        11828    11838      +10     
- Partials       1478     1481       +3     
Files Changed Coverage Δ
internal/pkg/cli/env_deploy.go 58.36% <0.00%> (-0.63%) ⬇️
internal/pkg/cli/errors.go 69.09% <0.00%> (-5.42%) ⬇️
internal/pkg/cli/job_deploy.go 39.29% <25.00%> (-0.19%) ⬇️
internal/pkg/cli/svc_deploy.go 38.31% <25.00%> (-0.11%) ⬇️

Comment thread internal/pkg/cli/svc_deploy.go Outdated
Copy link
Copy Markdown
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mergify mergify Bot merged commit ac4145e into aws:mainline Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants