chore: add default domain alias for static site#5191
Merged
mergify[bot] merged 6 commits intoaws:mainlinefrom Aug 18, 2023
Merged
chore: add default domain alias for static site#5191mergify[bot] merged 6 commits intoaws:mainlinefrom
mergify[bot] merged 6 commits intoaws:mainlinefrom
Conversation
KollaAdithya
changed the title
|
🍕 Here are the new binary sizes!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #5191 +/- ##
=========================================
Coverage 69.48% 69.49%
=========================================
Files 295 295
Lines 43926 43936 +10
Branches 285 286 +1
=========================================
+ Hits 30524 30534 +10
Misses 11909 11909
Partials 1493 1493 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // If the certificate domain is one of the aliases, expect one validation option for each alias. | ||
| // Otherwise, include an extra validation option for the certificate domain itself. | ||
| let expectedCount = aliases.has(certificateDomain) ? aliases.size : aliases.size + 1; |
Contributor
There was a problem hiding this comment.
Looks like we have the same problem with NLB as well: if they specify ${serviceName}-nlb.${envName}.${appName}.${domainName} as the NLB alias 🤔
Contributor
Author
There was a problem hiding this comment.
yes that's true, we are using the same custom resource for nlb alias as well.
iamhopaul123
approved these changes
Aug 17, 2023
Co-authored-by: Danny Randall <10566468+dannyrandall@users.noreply.github.com>
KollaAdithya
force-pushed
the
default/alias/staticsite
branch
from
572421c to
6dd50ee
Compare
dannyrandall
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5159
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.