Skip to content

chore: skip validation for ALB if config is disabled#5198

Merged
mergify[bot] merged 5 commits intoaws:mainlinefrom
KollaAdithya:mainline
Aug 18, 2023
Merged

chore: skip validation for ALB if config is disabled#5198
mergify[bot] merged 5 commits intoaws:mainlinefrom
KollaAdithya:mainline

Conversation

@KollaAdithya
Copy link
Copy Markdown
Contributor

address error part of the issue #5196

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya KollaAdithya requested a review from a team as a code owner August 16, 2023 23:07
@KollaAdithya KollaAdithya requested review from CaptainCarpensir and removed request for a team August 16, 2023 23:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 16, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51628 51488 +0.27
macOS (arm) 51828 51680 +0.29
linux (amd) 45452 45324 +0.28
linux (arm) 43716 43588 +0.29
windows (amd) 42256 42144 +0.27

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #5198 (32d0226) into mainline (f8b56cc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           mainline    #5198      +/-   ##
============================================
- Coverage     69.49%   69.49%   -0.01%     
============================================
  Files           295      295              
  Lines         43924    43926       +2     
  Branches        285      285              
============================================
+ Hits          30525    30526       +1     
+ Misses        11907    11906       -1     
- Partials       1492     1494       +2     
Files Changed Coverage Δ
internal/pkg/cli/deploy/lbws.go 57.86% <0.00%> (-1.11%) ⬇️

... and 1 file with indirect coverage changes

@mergify mergify Bot merged commit 185035a into aws:mainline Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants