chore: robustly ensure containers are stopped #5489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainCarpensir
requested review from
huanjani
and removed request for
a team
|
🍕 Here are the new binary sizes!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5489 +/- ##
============================================
+ Coverage 70.00% 70.01% +0.01%
============================================
Files 302 302
Lines 46124 46137 +13
Branches 309 309
============================================
+ Hits 32287 32301 +14
Misses 12264 12264
+ Partials 1573 1572 -1 ☔ View full report in Codecov by Sentry. |
iamhopaul123
approved these changes
Dec 3, 2023
dannyrandall
approved these changes
Dec 4, 2023
Contributor
dannyrandall
left a comment
dannyrandall
left a comment
There was a problem hiding this comment.
looks great! just a small nit 😊
dannyrandall
added
the
do-not-merge
CaptainCarpensir
removed
the
do-not-merge
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
Made a mistake in #5489 that causes an error message to falsely appear when stopping `run local` because it would call `docker inspect` when it only needed to call `docker ps`. This introduces another function that only runs the latter function, rather than running both, fixing the issue. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
docker psto ensure that the containers are stopped, instead of waiting 1 second and assuming that's enough time to stop them.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.