fix(pipeline): buildspec works with dockerfiles in subdirs #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
requested review from
a team,
bvtujo,
huanjani,
iamhopaul123,
kohidave and
seongm-1
Contributor
Author
|
Screenshot showing that two applications in the future, we can add an e2e test that follows this file hierarchy |
kohidave
approved these changes
May 6, 2020
iamhopaul123
approved these changes
May 6, 2020
|
Pulled in this change manually and tried it out and it work like a charm, thanks for great solution 👍🏻 |
bvtujo
pushed a commit
to bvtujo/copilot-cli
that referenced
this pull request
May 12, 2020
Fixes aws#893 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.