Polish dialog styles and button variants#1920
Merged
Merged
Conversation
Match bottom border width (border-y-2) between route buttons and sidebar tabs, and reduce sidebar tab font and icon size.
- Add outline-danger button variant for destructive secondary actions - Use DialogFooter in CreateConnection (resolves #1152) - Switch all dialog footer buttons from secondary to outline variant - Make DialogBody scroll independently of header/footer (matching AlertDialog) - Lighten the Dialog overlay opacity - Use primary variant on Done/Save buttons, outline on Cancel/Close - Add Cancel button to Create Namespace dialog
9998228 to
74a8236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consistency pass across dialog footers, button variants, and the dialog overlay/scroll model.
Button changes:
outline-dangervariant for destructive secondary actions (red text, danger-subtle hover, outlined border)outlineandprimaryvariants gainfont-basefor consistent weightDialog component changes:
DialogBodynow scrolls independently — header and footer stay fixed (matching AlertDialog)DialogOverlaylightened to 15% opacity and dialog content gets a stronger shadow for better separationDialogFootergainsbg-muted/50background with top borderUsage updates across all dialogs:
outlineprimaryoutline-dangerCreateConnectionrestructured to renderDialogBody/DialogFooteritself (was previously wrapped externally)primary, Copy to Clipboard →outlineHow to read
outline-dangervariantValidation
pnpm checkspasses (types, lint, format)pnpm testpasses — 31 dialog-rendering tests confirmedRelated Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.