Collapse styles cascade to a single user layer#1981
Merged
Conversation
Remove the never-shipped shared styles layer: delete the shared atoms and their IndexedDB keys, simplify the cascade to user over app defaults, and point import/export at the user styles. Replace the three Settings reset buttons with one Reset button, and give Save/Load/Reset matching icons. Update the glossary, styling ADRs, and settings docs to the single-layer model, and align UI copy to 'default style' with query-language type labels. No data migration — the shared layer never shipped.
kmcginnes
marked this pull request as ready for review
July 21, 2026 03:48
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Collapses the two-layer styling architecture (shared + user) into a single user styles layer. The shared layer was internal and never shipped, so this removes it wholesale with no data migration.
Core change:
sharedVertexStylesAtom/sharedEdgeStylesAtomand their IndexedDB keys.{...appDefault, ...user}—resolveVertexStyle/resolveEdgeStyleno longer take a shared parameter.Settings → Styles stays as the home for save/load/reset, now single-layer:
Supporting cleanup:
docs/features/settings.mdupdated to the single-layer model; staleshared-vertex-stylesreferences removed from two adjacent ADRs.Out of scope (deferred): the selective import modal (#1972), relocating the buttons to the sidebar, and the
styling-exportenvelope-kind rename.How to read
Validation
pnpm checkspasses (types, lint, format).pnpm testpasses.DbStateshared-style helpers removed.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.