feat(jsii-pacmak): allow disabling go build conditionally#4196
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Jul 26, 2023
Merged
feat(jsii-pacmak): allow disabling go build conditionally#4196mergify[bot] merged 3 commits intoaws:mainfrom
mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
RomainMuller
suggested changes
Jul 26, 2023
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
RomainMuller
approved these changes
Jul 26, 2023
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CDKTF this step causes our examples to take up to 24GB of Ram and ~5 minutes to have the bindings generated. We split our code into a lot of modules, so if a user just ran
go run ...and only the parts needed would be compiled they can save a lot of time and resources.