Fix logging behavior #287
Merged
Fix logging behavior #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
had a problem deploying
to
manual-approval
GitHub Actions
Failure
benieric
reviewed
Apr 16, 2025
| handler = get_rich_handler() | ||
| logging.basicConfig(level=getattr(logging, log_level), handlers=[handler]) | ||
| logger = logging.getLogger(name) | ||
| logger.addHandler(handler) |
Contributor
There was a problem hiding this comment.
would it make sense to clear all handlers before adding this one back? If this gets called twice could end up with duplicate logs being printed
for handler in logger.handlers:
logger.removeHandler(handler)
logger.addHandler(handler)
Contributor
Author
There was a problem hiding this comment.
Makes sense, fixed!
Contributor
Author
There was a problem hiding this comment.
fixed style issue.
Contributor
There was a problem hiding this comment.
I think may need to run black .
abdulfatir
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
benieric
previously approved these changes
Apr 16, 2025
abdulfatir
had a problem deploying
to
manual-approval
GitHub Actions
Failure
abdulfatir
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Contributor
Author
|
black issue is unrelated to this PR |
benieric
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #286, also see aws/sagemaker-python-sdk#4945
Description of changes: This PR modifies logging utils such that the root logger behavior through
basicConfigis not changed, rather the log level and handler are changed for thesagemaker_core.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.