Skip to content

Fix logging behavior #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Fix logging behavior #287

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d491e8
Fix log level change
abdulfatir Apr 16, 2025
c09df76
Remove handler before adding
abdulfatir Apr 16, 2025
304f062
code style
abdulfatir Apr 16, 2025
f134c47
Update utils.py
abdulfatir Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sagemaker_core/main/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,11 @@ def get_textual_rich_logger(name: str, log_level: str = "INFO") -> logging.Logge
"""
enable_textual_rich_console_and_traceback()
handler = get_rich_handler()
logging.basicConfig(level=getattr(logging, log_level), handlers=[handler])
logger = logging.getLogger(name)
for handler in logger.handlers:
logger.removeHandler(handler)
logger.addHandler(handler)
Copy link
Contributor

@benieric benieric Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to clear all handlers before adding this one back? If this gets called twice could end up with duplicate logs being printed

for handler in logger.handlers:
	logger.removeHandler(handler)
logger.addHandler(handler)

Copy link
Contributor Author

@abdulfatir abdulfatir Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, fixed!

Copy link
Contributor

@benieric benieric Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Copy link
Contributor Author

@abdulfatir abdulfatir Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed style issue.

Copy link
Contributor

@benieric benieric Apr 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think may need to run black .

logger.setLevel(getattr(logging, log_level))

return logger

Expand Down
Loading