feat(telemetry): Add tracking for dry_run, notifications, reuse - #6159
Conversation
…/deployment/evaluation subfolders
…rces, show_metrics, and stream_logs
| feature=Feature.MODEL_CUSTOMIZATION, | ||
| func_name="BaseTrainer.stream_logs", | ||
| telemetry_params=[ | ||
| ("_model_name", TelemetryParamType.ATTR_VALUE), |
There was a problem hiding this comment.
Do we have approval to collect this in telemetry?
There was a problem hiding this comment.
Yes we are reusing the decorator _telemetry_emitter. It has been used in other places
|
Few more spots where we can add telemetry: |
| func_name="BedrockModelBuilder.deploy", | ||
| telemetry_params=[ | ||
| ("model_package", TelemetryParamType.ATTR_EXISTS), | ||
| ("_is_nova_model_for_telemetry", TelemetryParamType.ATTR_CALL), |
There was a problem hiding this comment.
how does this work? What if bedrock model builder doesn't call _is_nova_model_for_telemetry() and calls _is_nova_model instead?
There was a problem hiding this comment.
so every time BedrockModelBuilder.deploy() is called, the decorator runs _is_nova_model_for_telemetry before the actual deploy() body executes. The actual method called inside deploy doesn't matter
There was a problem hiding this comment.
Thanks for explaining.
feat(telemetry): Add tracking for dry_run, notifications, reuse