Skip to content

feat(telemetry): Add tracking for dry_run, notifications, reuse - #6159

Merged
zhaoqizqwang merged 8 commits into
aws:master-nova-follow-upsfrom
zhaoqizqwang:sa-feedback
Aug 5, 2026
Merged

feat(telemetry): Add tracking for dry_run, notifications, reuse#6159
zhaoqizqwang merged 8 commits into
aws:master-nova-follow-upsfrom
zhaoqizqwang:sa-feedback

Conversation

@zhaoqizqwang

Copy link
Copy Markdown
Collaborator

feat(telemetry): Add tracking for dry_run, notifications, reuse

feature=Feature.MODEL_CUSTOMIZATION,
func_name="BaseTrainer.stream_logs",
telemetry_params=[
("_model_name", TelemetryParamType.ATTR_VALUE),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have approval to collect this in telemetry?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are reusing the decorator _telemetry_emitter. It has been used in other places

@mujtaba1747

Copy link
Copy Markdown
Collaborator

Few more spots where we can add telemetry:
evaluators dry run
stream logs / show metrics for evaluators (not sure if we implemented this for Evaluators)
model reuse for bedrock modelbuilder
Ideally if the model reuse telemetry can also show if model is_nova or not, that would be great, but it's a nice to have.

func_name="BedrockModelBuilder.deploy",
telemetry_params=[
("model_package", TelemetryParamType.ATTR_EXISTS),
("_is_nova_model_for_telemetry", TelemetryParamType.ATTR_CALL),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work? What if bedrock model builder doesn't call _is_nova_model_for_telemetry() and calls _is_nova_model instead?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so every time BedrockModelBuilder.deploy() is called, the decorator runs _is_nova_model_for_telemetry before the actual deploy() body executes. The actual method called inside deploy doesn't matter

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining.

@zhaoqizqwang
zhaoqizqwang merged commit a27fbb7 into aws:master-nova-follow-ups Aug 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants