Skip to content

Conversation

@ShreyaGangishetty
Copy link

Issue #, if available:
#1486

Description of changes:
Release v1.22.0

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

keetonian and others added 30 commits February 4, 2020 14:10
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #1519 into master will decrease coverage by 0.56%.
The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   94.67%   94.11%   -0.57%     
==========================================
  Files          78       78              
  Lines        5056     4942     -114     
  Branches     1100      996     -104     
==========================================
- Hits         4787     4651     -136     
- Misses        124      135      +11     
- Partials      145      156      +11
Impacted Files Coverage Δ
samtranslator/model/cognito.py 85.71% <ø> (ø) ⬆️
samtranslator/model/apigateway.py 97.1% <ø> (-0.55%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 71.42% <ø> (ø) ⬆️
samtranslator/plugins/globals/globals.py 99.05% <ø> (ø) ⬆️
samtranslator/model/eventsources/push.py 90.84% <100%> (-0.51%) ⬇️
...el/preferences/deployment_preference_collection.py 91.35% <100%> (ø) ⬆️
samtranslator/model/apigatewayv2.py 93.93% <100%> (+0.18%) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️
samtranslator/plugins/api/implicit_api_plugin.py 98.24% <100%> (+0.01%) ⬆️
samtranslator/model/eventsources/pull.py 82.27% <100%> (+0.22%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a278ff...dd1c3d3. Read the comment docs.

@ShreyaGangishetty ShreyaGangishetty merged commit a12feb6 into master Mar 16, 2020
@mhart
Copy link

mhart commented Mar 24, 2020

So this release introduced a breaking change and really shouldn't have been a minor release.

This can easily be observed by all the tests that were changed from "payloadFormatVersion": "1.0" to "payloadFormatVersion": "2.0" – if your tests require that change, then everyone's code is also going to require a change.

We managed to fix this within a few hours of deployment to production, but it was very hard to find – especially when defaults change from under your feet.

Can we have some sort of assurance that breaking changes like this will be avoided in the future – and if they are made, then a new SAM transform version is used?

@sapessi
Copy link

sapessi commented Apr 3, 2020

Hi @mhart,

I apologize for the impact. Our process does require breaking changes like this be accompanied by a version change and appropriate communication, but it’s clear we did not follow it here. We are root causing what happened internally and will add additional controls to prevent it from recurring again. Thank you again for the feedback.

@jfuss jfuss deleted the release/v1.22.0 branch October 8, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.