-
Couldn't load subscription status.
- Fork 2.4k
Release/v1.22.0 #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v1.22.0 #1519
Conversation
merge develop into v1.22.0
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
- Coverage 94.67% 94.11% -0.57%
==========================================
Files 78 78
Lines 5056 4942 -114
Branches 1100 996 -104
==========================================
- Hits 4787 4651 -136
- Misses 124 135 +11
- Partials 145 156 +11
Continue to review full report at Codecov.
|
|
So this release introduced a breaking change and really shouldn't have been a minor release. This can easily be observed by all the tests that were changed from We managed to fix this within a few hours of deployment to production, but it was very hard to find – especially when defaults change from under your feet. Can we have some sort of assurance that breaking changes like this will be avoided in the future – and if they are made, then a new SAM transform version is used? |
|
Hi @mhart, I apologize for the impact. Our process does require breaking changes like this be accompanied by a version change and appropriate communication, but it’s clear we did not follow it here. We are root causing what happened internally and will add additional controls to prevent it from recurring again. Thank you again for the feedback. |
Issue #, if available:
#1486
Description of changes:
Release v1.22.0
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.