Feature - API Token Management UI#613
Merged
Merged
Conversation
bedanley
reviewed
Dec 12, 2025
| expiration = request.tokenExpiration or int((datetime.now() + timedelta(days=90)).timestamp()) | ||
|
|
||
| # Store in DynamoDB | ||
| item = { |
Contributor
There was a problem hiding this comment.
You should have a pydantic model that sets the default values if one isn't provided.
bedanley
reviewed
Dec 12, 2025
|
|
||
| event = request.scope["aws.event"] | ||
| current_user = get_username(event) | ||
| is_admin_user = is_admin(event) |
Contributor
There was a problem hiding this comment.
You can try the admin_only annotation
bedanley
reviewed
Dec 12, 2025
|
|
||
| event = request.scope["aws.event"] | ||
| current_user = get_username(event) | ||
| is_admin_user = is_admin(event) |
Contributor
There was a problem hiding this comment.
There is also the get_user_context(), which returns both the username and is_admin tuple
bedanley
reviewed
Dec 12, 2025
| token_info = is_valid_api_token(id_token) | ||
| if token_info: | ||
| # Use actual values from token | ||
| # TODO: Remove default api-token. |
Contributor
There was a problem hiding this comment.
Do we have default api-tokens? Not the management key.
bedanley
reviewed
Dec 12, 2025
| const paginatedTokens = filteredTokens.slice(startIndex, startIndex + preferences.pageSize); | ||
|
|
||
| const formatDate = (timestamp: number) => { | ||
| return new Date(timestamp * 1000).toLocaleString(); |
Contributor
There was a problem hiding this comment.
Can we create the value correctly in the backend?
bedanley
previously approved these changes
Dec 17, 2025
bedanley
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.