Skip to content

H2B: More incremental progres #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Oct 15, 2019
Merged

H2B: More incremental progres #149

merged 31 commits into from
Oct 15, 2019

Conversation

@dislogical
Copy link
Contributor

@dislogical dislogical commented Oct 4, 2019 •
edited
Loading

Contains the following additions:

  • H2 Stream State machine
  • HTTP error codes for common H2 errors (raising H2_PROTOCOL_ERROR was actually super terrible)
  • H2 Connection class framing
  • H2 Decoder class framing
  • H1 Connection header file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dislogical dislogical requested a review from a team October 4, 2019 21:08
justinboswell
justinboswell approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@justinboswell justinboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix-n-ship

graebm
graebm reviewed Oct 11, 2019
View reviewed changes
graebm
graebm approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

@dislogical dislogical merged commit b4f26ae into master Oct 15, 2019
@dislogical dislogical deleted the h2b branch October 15, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graebm graebm graebm approved these changes

+1 more reviewer

@justinboswell justinboswell justinboswell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dislogical @justinboswell @graebm