Skip to content

Fix bug when new request has same memory address as old request. #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix bug when new request has same memory address as old request. #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions source/h1_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ static void s_client_update_incoming_stream_ptr(struct h1_connection *connection
*/
static struct aws_h1_stream *s_update_outgoing_stream_ptr(struct h1_connection *connection) {
struct aws_h1_stream *current = connection->thread_data.outgoing_stream;
struct aws_h1_stream *prev = current;
bool current_changed = false;
int err;

/* If current stream is done sending data... */
Expand Down Expand Up @@ -683,6 +683,7 @@ static struct aws_h1_stream *s_update_outgoing_stream_ptr(struct h1_connection *
}

current = NULL;
current_changed = true;
}

/* If current stream is NULL, look for more work. */
Expand Down Expand Up @@ -720,6 +721,7 @@ static struct aws_h1_stream *s_update_outgoing_stream_ptr(struct h1_connection *

/* We found a stream to work on! */
current = stream;
current_changed = true;
break;
}

Expand All @@ -733,7 +735,7 @@ static struct aws_h1_stream *s_update_outgoing_stream_ptr(struct h1_connection *
}

/* Update current incoming and outgoing streams. */
if (prev != current) {
if (current_changed) {
AWS_LOGF_TRACE(
AWS_LS_HTTP_CONNECTION,
"id=%p: Current outgoing stream is now %p.",
Expand Down