Skip to content

Conversation

@graebm
Copy link
Contributor

@graebm graebm commented Apr 20, 2020

HTTP/2 connection sends GOAWAY on error, or during normal shutdown.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm requested review from a team and TingDaoK April 20, 2020 17:50
Copy link
Contributor

@justinboswell justinboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix-n-shipperooni

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant implementation! Do we need some TODOs to server stuff? Like attempting to gracefully shut down a connection.

@graebm
Copy link
Contributor Author

graebm commented Apr 20, 2020

Elegant implementation! Do we need some TODOs to server stuff? Like attempting to gracefully shut down a connection.

There's no guarantee we'll ever actually do a server implementation. I'm saving "TODO" comments just for stuff we know we'll need in the next month or two.

HTTP/2 connection sends GOAWAY on error, or during normal shutdown.
@graebm graebm merged commit c604f6b into master Apr 21, 2020
@graebm graebm deleted the send-goaway branch April 21, 2020 23:04
czakian pushed a commit to czakian/aws-c-http that referenced this pull request Apr 24, 2020
HTTP/2 connection sends GOAWAY on error, or during normal shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants