Skip to content

Conversation

@TingDaoK
Copy link
Contributor

Issue #, if available:

Description of changes:

Receive GOAWAY frame

  • Stop creating and sending new streams.
  • Mark the streams with higher ID than the last_stream_id indicated by the GOAWAY frame as completed with error to inform the user to retry them on a new connection.

TODO:

  • Inform our user about the debug information in GOAWAY.

@TingDaoK TingDaoK changed the title Recv goaway frame Receive GOAWAY Apr 20, 2020
@TingDaoK TingDaoK requested review from a team and graebm April 20, 2020 19:43
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Nothing but string tweak suggestions

@TingDaoK TingDaoK merged commit d383e95 into master Apr 21, 2020
@TingDaoK TingDaoK deleted the recv-goaway branch April 21, 2020 03:10
czakian pushed a commit to czakian/aws-c-http that referenced this pull request Apr 24, 2020
Receive GOAWAY frame:
- Stop creating and sending new streams.
- Mark the streams with higher ID than the last_stream_id indicated by the GOAWAY frame as completed with error to inform the user to retry them on a new connection.
TODO:
- Inform our user about the debug information in GOAWAY.

Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Dengke Tang <dengket@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants