Metric for manager #370
Metric for manager #370
Conversation
| */ | ||
| AWS_HTTP_API | ||
| void aws_http_connection_manager_fetch_metric( | ||
| struct aws_http_connection_manager *manager, |
There was a problem hiding this comment.
trivial: if you change "metric" -> "metrics" update this function name too
| */ | ||
| AWS_HTTP_API | ||
| void aws_http2_stream_manager_fetch_metric( | ||
| struct aws_http2_stream_manager *http2_stream_manager, |
There was a problem hiding this comment.
trivial: is this non-const because you need to acquire the lock?
If so, I'd be OK with making this const, and then just casting away the const-ness when you need to futz with the locks.
In principal it's const
| */ | ||
| AWS_HTTP_API | ||
| void aws_http_connection_manager_fetch_metric( | ||
| struct aws_http_connection_manager *manager, |
There was a problem hiding this comment.
trivial: if you change "metric" -> "metrics" update this function name too
| */ | ||
| AWS_HTTP_API | ||
| void aws_http2_stream_manager_fetch_metric( | ||
| struct aws_http2_stream_manager *http2_stream_manager, |
There was a problem hiding this comment.
trivial: is this non-const because you need to acquire the lock?
If so, I'd be OK with making this const, and then just casting away the const-ness when you need to futz with the locks.
In principal it's const
| struct aws_http_manager_metric *out_metric); | ||
| void aws_http_connection_manager_fetch_metrics( | ||
| const struct aws_http_connection_manager *manager, | ||
| struct aws_http_manager_metrics *out_metric); |
There was a problem hiding this comment.
trivial: out_metric -> out_metrics
some compilers issue warnings if the param name is different between the .h and .c file
2 participants
Provide API to fetch metric for managers.
To support https://github.com/aws/aws-sdk-java-v2/blob/master/http-client-spi/src/main/java/software/amazon/awssdk/http/HttpMetric.java#L65
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.