Release v0.15.15

[aceeric]

This PR supports the ability to perform S3 get and put operations over HTTP as well as HTTPS, and with custom ports. This PR integrates with changes to the aws-c-s3 repo/submodule made in this commit: awslabs/aws-c-s3@2a37467

[TingDaoK]

Do you also update the submodule aws-c-s3? Can you open a PR to that as well?

[aceeric]

@TingDaoK Hello - per your request please see PR: awslabs/aws-c-s3#174

[aceeric]

@TingDaoK Hello - I updated this PR and the corresponding one here: awslabs/aws-c-s3#174 to pass the URI into the C code.

[TingDaoK]

can you use the same pattern to include the dependency? So, something like #include <aws/io/uri.h>

[aceeric]

ok done

[TingDaoK]

Well, I think we can handle this error. That should not crash the program.

Suggested change

	AWS_FATAL_ASSERT(aws_uri_init_parse(&endpoint, allocator, &endpoint_str) == AWS_OP_SUCCESS);
	if (aws_uri_init_parse(&endpoint, allocator, &endpoint_str)) {
	aws_jni_throw_runtime_exception(env, "S3Client.aws_s3_client_make_meta_request: failed to parse endpoint");
	aws_jni_byte_cursor_from_jbyteArray_release(env, jni_endpoint, endpoint_str);
	goto done;
	}

Also, for proper clean up, you need to move the endpoint part after request_message created, as we clean up the resources from done tag

[aceeric]

done - handled the error very slightly differently to call aws_jni_byte_cursor_from_jbyteArray_release only once

[TingDaoK]

looks good! Thank you!

[aceeric]

I noticed the Windows build was failing. It was complaining about ref to meta_request. I build on Linux no issues. Even so I moved the declaration to the top of the function so I don't see a way the Windows compiler can complain about it now

[aceeric]

@TingDaoK Hello - Thank you for your help - is there anything else needed from me to get this into the main branch?

[TingDaoK]

Nope, thank you. I merged for you, let me know if you need a new release to use it from maven.

[aceeric]

Super - thank you. If you can release to Maven we would appreciate it because we have some in-house code that presently uses a patched JAR and it would be better to use the official Maven release version. Thanks.