Allow passing None for the PKCS11 user pin#446
Merged
Conversation
graebm
reviewed
Feb 16, 2023
graebm
approved these changes
Feb 16, 2023
Contributor
Author
|
Thanks! Merging into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The documentation for the PKCS11
create_client_with_mtls_pkcs11()function states that you can passNoneas a valid input, but this is not allowed becauseuser_pinis not set toNoneby default. When using Python with typing, this causes problems.This PR fixes that by making the
user_pinoptional by setting it tonullby default. It also adjusts the C code to check if the value isnulland, if it is, it passes a zeroed outaws_byte_cursor.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.