Skip to content

Conversation

@hsuamz
Copy link
Contributor

@hsuamz hsuamz commented Dec 15, 2021

Summary

Documentation review and changes for the upcoming 0.4.0 release.

Description

  • Reviewed Connection Plugin Manager and Enhanced Failure Monitoring sections.
  • Updated wording for the general README.

@hsuamz hsuamz requested a review from sergiyvamz December 15, 2021 19:50
### Connection Plugin Manager
Connection plugin manager initializes, triggers, and cleans up a chain of connection plugins. Connection plugins are widgets attached to each `Connection` objects to help execute additional or supplementary logic related to that `Connection`. [Enhanced Failure Monitoring](https://github.com/awslabs/aws-mysql-jdbc#enhanced-failure-monitoring) is one example of a connection plugin.
The connection plugin manager initializes, triggers, and cleans up a chain of connection plugins. Connection plugins are widgets attached to each `Connection` object to help execute additional or supplementary logic related to that `Connection`. [Enhanced Failure Monitoring](https://github.com/awslabs/aws-mysql-jdbc#enhanced-failure-monitoring) is one example of a connection plugin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I look at it the more awkward this line looks.

Enhanced Failure Monitoring is one example of a connection plugin.

I think we should refer to the feature as Enhanced Failure Monitoring and refer the plugin as Enhanced Failure Monitoring Connection Plugin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better phrased:

Enhanced Failure Monitoring is just one example of a connection plugin; you can use the 'Enhanced Failure Monitoring' Connection plugin to implement the functionality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we rename Enhanced Failure Monitoring to Enhanced Failure Monitoring Plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's do that name change. I'll merge this PR in and we can open up another PR that does the renaming.

@hsuamz hsuamz merged commit e458f4e into main Dec 16, 2021
@hsuamz hsuamz deleted the readme_review branch December 16, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants