fix: ANY_STRING_EQUALS waiter matcher match on one string #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Jul 10, 2025
| let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0] | ||
| let match = subject.evaluate(input: anInput, result: .success(output)) | ||
| XCTAssertEqual(match, .success(.success(output))) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The test case above is the specific scenario that the bugfix addresses.
The other three tests here were added for completeness.
sichanyoo
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1981
Description of changes
Adds test for matching
ALL_STRING_EQUALSfor one string.This test verifies a bugfix in smithy-lang/smithy-swift#947.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.