Skip to content

fix: ANY_STRING_EQUALS waiter matcher match on one string #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

fix: ANY_STRING_EQUALS waiter matcher match on one string #1982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b36398
fix: ANY_STRING_EQUALS waiter matcher match on one string
jbelkins Jul 10, 2025
65adeab
Add more test cases for string list matching
jbelkins Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion ...otocol-test-codegen-local/Tests/swift-codegen/Tests/WaitersTests/OutputMatcherTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,35 @@ class OutputMatcherTests: XCTestCase {
// JMESPath comparator: "allStringEquals"
// JMESPath expected value: "abc"

func test_projection_acceptorMatchesWhenProjectedValuesMatchExpectation() async throws {
func test_projection_acceptorDoesNotMatchWhenProjectedValueIsNil() async throws {
let output = GetWidgetOutput(dataMap: nil)
let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0]
let match = subject.evaluate(input: anInput, result: .success(output))
XCTAssertNil(match)
}

func test_projection_acceptorDoesNotMatchWhenProjectedValueIsEmpty() async throws {
let output = GetWidgetOutput(dataMap: [:])
let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0]
let match = subject.evaluate(input: anInput, result: .success(output))
XCTAssertNil(match)
}

func test_projection_acceptorMatchesWhenSingleProjectedValueMatchesExpectation() async throws {
let output = GetWidgetOutput(dataMap: ["x": "abc"])
let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0]
let match = subject.evaluate(input: anInput, result: .success(output))
XCTAssertEqual(match, .success(.success(output)))
}
Copy link
Contributor Author

@jbelkins jbelkins Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case above is the specific scenario that the bugfix addresses.

The other three tests here were added for completeness.


func test_projection_acceptorMatchesWhenSingleProjectedValueDoesNotMatchExpectation() async throws {
let output = GetWidgetOutput(dataMap: ["x": "def"])
let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0]
let match = subject.evaluate(input: anInput, result: .success(output))
XCTAssertNil(match)
}

func test_projection_acceptorMatchesWhenMultipleProjectedValuesMatchExpectation() async throws {
let output = GetWidgetOutput(dataMap: ["x": "abc", "y": "abc", "z": "abc"])
let subject = try WaitersClient.projectionMatcherWaiterConfig().acceptors[0]
let match = subject.evaluate(input: anInput, result: .success(output))
Expand Down
Loading