Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion awsshell/wizard.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import sys
import copy
import json
import logging
import jmespath

import botocore.session
Expand All @@ -15,6 +16,9 @@
from prompt_toolkit.shortcuts import confirm


LOG = logging.getLogger(__name__)


def stage_error_handler(error, stages, confirm=confirm, prompt=select_prompt):
managed_errors = (
ClientError,
Expand Down Expand Up @@ -372,5 +376,10 @@ def resolve_parameters(self, keys):
"""
resolved_dict = {}
for key in keys:
resolved_dict[key] = self.retrieve(keys[key])
retrieved = self.retrieve(keys[key])
if retrieved is not None:
resolved_dict[key] = retrieved
else:
LOG.debug("Query failed (%s), dropped key: %s", keys[key], key)

return resolved_dict
6 changes: 6 additions & 0 deletions tests/unit/test_wizard.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ def test_resolve_parameters():
assert resolved == {'a': 'Nice', 'b': 'v'}


def test_resolve_parameters_drops_none(env):
keys = {'a': 'bad.query', 'b': 'env_var.epic'}
resolved = env.resolve_parameters(keys)
assert resolved == {'b': 'nice'}


@pytest.fixture
def loader(wizard_spec):
session = mock.Mock()
Expand Down