Align configs between lexical-graph and byokg-rag#163
Merged
iansrobinson merged 2 commits intoawslabs:mainfrom Mar 25, 2026
Merged
Align configs between lexical-graph and byokg-rag#163iansrobinson merged 2 commits intoawslabs:mainfrom
iansrobinson merged 2 commits intoawslabs:mainfrom
Conversation
- Align byokg-rag .coveragerc with lexical-graph: add missing exclude_lines patterns (def __str__, @abc.abstractmethod, typing.TYPE_CHECKING, return NotImplemented, pass, ellipsis) - Set sub-module specific fail_under thresholds (lexical-graph: 40, byokg-rag: 80) - Remove pytest from byokg-rag runtime requirements.txt (test-only dep) - Add HTML coverage report to lexical-graph pyproject.toml to match byokg-rag
- Remove redundant byokg-rag/.gitignore - Add dist/, build/, *.egg-info/ to root .gitignore
acarbonetto
approved these changes
Mar 24, 2026
| */prompts/* | ||
|
|
||
| [report] | ||
| fail_under = 80 |
Collaborator
There was a problem hiding this comment.
Suggested change
| fail_under = 80 | |
| fail_under = 90 |
we're over 95% right now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes coverage, test, and build configs across both sub-projects to reduce drift and fix a packaging bug.
Changes
Coverage & test config alignment
.coveragercwith lexical-graph: add missingexclude_linespatterns (def __str__,@abc.abstractmethod,typing.TYPE_CHECKING,return NotImplemented,pass,...)fail_underthresholds (lexical-graph: 40, byokg-rag: 80)--cov-report=html:htmlcov) to lexical-graphpyproject.tomlto match byokg-ragpytest==8.4.2from byokg-rag runtimerequirements.txt— it was leaking into end-user installs as a transitive dependency.gitignore consolidation
byokg-rag/.gitignoredist/,build/,*.egg-info/to root.gitignoreto backfill coverageTesting
No behavioral changes — config-only. CI coverage thresholds and exclude patterns will take effect on next test run.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.