Fix launch template name for MNG creation #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavi-koduru
commented
Sep 26, 2025
| launch_template_name="$(params.cluster-name)-launchTemplate" | ||
| if [ -n "$(params.launch-template-name)" ]; then | ||
| launch_template_name="$(params.launch-template-name)" | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
We currently perform a similar check for SMNG creation. -https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/tests/tekton-resources/tasks/setup/eks/awscli-smng.yaml#L81-L84
Contributor
There was a problem hiding this comment.
Which pipeline is running into this?
Based on the pipeline definitions in mainline branch, steps that use the managed-nodegroup creation (awscli-mng) tasks arent passing the launch-template-name param so this would be a no-op for now.
Contributor
|
/approve |
hakuna-matatah
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There is mismatch between launch template name while creation and usage. Fixing the launch template used while creating MNG
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.