Skip to content

Fix launch template name for MNG creation #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Fix launch template name for MNG creation #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/tekton-resources/tasks/setup/eks/awscli-mng.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ spec:
create_and_validate_dp_nodes()
{
node_group_name=$node_group-$1
launch_template_name=$(params.cluster-name)-launchTemplate
# by default assume <cluster-name>-launchTemplate convention
launch_template_name="$(params.cluster-name)-launchTemplate"
if [ -n "$(params.launch-template-name)" ]; then
launch_template_name="$(params.launch-template-name)"
fi
Copy link
Contributor Author

@bhavi-koduru bhavi-koduru Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently perform a similar check for SMNG creation. -https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/tests/tekton-resources/tasks/setup/eks/awscli-smng.yaml#L81-L84

Copy link
Contributor

@shvbsle shvbsle Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which pipeline is running into this?
Based on the pipeline definitions in mainline branch, steps that use the managed-nodegroup creation (awscli-mng) tasks arent passing the launch-template-name param so this would be a no-op for now.

ex. https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/tests/tekton-resources/pipelines/eks/awscli-cl2-load-with-addons-slos.yaml#L223-L245

CREATED_NODEGROUP=$(aws eks $ENDPOINT_FLAG --region $(params.region) list-nodegroups --cluster-name $(params.cluster-name) --query 'nodegroups[?@==`'$node_group_name'`]' --output text)
EC2_INSTANCES=$3
if [ "$CREATED_NODEGROUP" == "" ]; then
Expand Down