feat: make status histogram buckets configurable#164
Merged
jonathan-innis merged 2 commits intoawslabs:mainfrom Jun 24, 2025
Merged
feat: make status histogram buckets configurable#164jonathan-innis merged 2 commits intoawslabs:mainfrom
jonathan-innis merged 2 commits intoawslabs:mainfrom
Conversation
jonathan-innis
approved these changes
Jun 24, 2025
Contributor
jonathan-innis
left a comment
There was a problem hiding this comment.
Nice! Thanks for the change! 🎉
Contributor
Author
|
Thanks @jonathan-innis - is there anything extra needed to pass the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue #, if available:
Description of changes:
Following breadcrumbs from Karpenter.
We are drilling into attributing costs to the lifecycle of Nodes (EC2 instances) within our platform. The Karpenter project uses
awslabs/operatorpkgto emit metrics on status condition changes for CRDs likeNodeClaimandNodePool- exactly what we are after.Unfortunately, these metrics are emitted as histograms with non configurable buckets (defaults to
prometheus.DefBuckets). As objects likeNodeClaimcan take seconds to many minutes (or longer) to transition state, the default max bucket of 5seconds makes these metrics less useful.This PR allows consumers to optionally configure the histogram metrics buckets, keeping the existing default behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.